Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Updated AIM instrumentation #2015

Merged
merged 1 commit into from
Feb 14, 2024
Merged

refactor: Updated AIM instrumentation #2015

merged 1 commit into from
Feb 14, 2024

Conversation

bizob2828
Copy link
Member

Description

This PR addresses a few items that were codified into the specification that we were missing:

  • remove capturing api key
  • update tracking metric to start with Supportability/Nodejs/ML
  • include any custom attributes that start with llm. except llm.conversation_id as attributes on all Llm Events.

Related Issues

Closes #2007

Verified

This commit was signed with the committer’s verified signature.
jsumners-nr James Sumners
…pi key, include all custom attributes prefixed with `llm.` as attributes on all Llm Events and change tracking metric to start with Supportability
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4daedc0) 97.10% compared to head (ab0c96d) 97.13%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2015      +/-   ##
==========================================
+ Coverage   97.10%   97.13%   +0.02%     
==========================================
  Files         239      239              
  Lines       41017    41050      +33     
==========================================
+ Hits        39831    39875      +44     
+ Misses       1186     1175      -11     
Flag Coverage Δ
integration-tests-16.x 78.78% <38.88%> (+0.04%) ⬆️
integration-tests-18.x 78.78% <38.88%> (+0.05%) ⬆️
integration-tests-20.x 78.78% <38.88%> (+0.05%) ⬆️
unit-tests-16.x 91.16% <100.00%> (+0.08%) ⬆️
unit-tests-18.x 91.05% <100.00%> (+0.08%) ⬆️
unit-tests-20.x 91.05% <100.00%> (+0.08%) ⬆️
versioned-tests-16.x 74.98% <77.77%> (+0.01%) ⬆️
versioned-tests-18.x 75.00% <77.77%> (+0.01%) ⬆️
versioned-tests-20.x 75.01% <77.77%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jsumners-nr jsumners-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@bizob2828 bizob2828 closed this Feb 14, 2024
@bizob2828 bizob2828 reopened this Feb 14, 2024
@bizob2828 bizob2828 changed the title refactor: Updated AIM instrumentation to remove capturing last 4 of api key, include all custom attributes prefixed with llm. as attributes on all Llm Events and change tracking metric to start with Supportability refactor: Updated AIM instrumentation Feb 14, 2024
@bizob2828 bizob2828 merged commit d37d2a8 into main Feb 14, 2024
23 checks passed
@bizob2828 bizob2828 deleted the aim-followup branch February 14, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

OpenAI: add metadata and change tracking metric
2 participants