Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Updated capturing conversation_id on Llm Events as llm.conversation_id #2020

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

bizob2828
Copy link
Member

Description

Moves conversation_id to llm.conversation_id and have it apply to all Llm Events.

Related Issues

Closes #2019

…versation_id`
Copy link
Contributor

@jsumners-nr jsumners-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d37d2a8) 97.11% compared to head (e36390c) 97.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2020      +/-   ##
==========================================
- Coverage   97.11%   97.10%   -0.01%     
==========================================
  Files         239      239              
  Lines       41050    41037      -13     
==========================================
- Hits        39864    39851      -13     
  Misses       1186     1186              
Flag Coverage Δ
integration-tests-16.x 78.70% <0.00%> (+0.02%) ⬆️
integration-tests-18.x 78.67% <0.00%> (-0.01%) ⬇️
integration-tests-20.x 78.69% <0.00%> (+<0.01%) ⬆️
unit-tests-16.x 91.09% <75.00%> (-0.01%) ⬇️
unit-tests-18.x 90.98% <75.00%> (-0.01%) ⬇️
unit-tests-20.x 90.98% <75.00%> (-0.01%) ⬇️
versioned-tests-16.x 75.04% <100.00%> (+0.12%) ⬆️
versioned-tests-18.x 75.07% <100.00%> (+0.12%) ⬆️
versioned-tests-20.x 75.07% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bizob2828 bizob2828 merged commit 5f93f65 into newrelic:main Feb 14, 2024
@bizob2828 bizob2828 deleted the conversation-id branch August 28, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Capture conversation_id as llm.conversation_id on all LLM events
2 participants