Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add LangChain error events capture #2040

Merged
merged 4 commits into from
Feb 26, 2024

Conversation

jsumners-nr
Copy link
Contributor

This PR resolves issue #1969.

@jsumners-nr jsumners-nr marked this pull request as ready for review February 26, 2024 13:46
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.16%. Comparing base (b9c73ca) to head (08f879e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2040   +/-   ##
=======================================
  Coverage   97.15%   97.16%           
=======================================
  Files         248      248           
  Lines       41600    41648   +48     
=======================================
+ Hits        40418    40466   +48     
  Misses       1182     1182           
Flag Coverage Δ
integration-tests-16.x 78.51% <12.19%> (-0.08%) ⬇️
integration-tests-18.x 78.47% <12.19%> (-0.09%) ⬇️
integration-tests-20.x 78.48% <12.19%> (-0.07%) ⬇️
unit-tests-16.x 90.81% <17.07%> (-0.08%) ⬇️
unit-tests-18.x 90.79% <17.07%> (-0.08%) ⬇️
unit-tests-20.x 90.79% <17.07%> (-0.08%) ⬇️
versioned-tests-16.x 74.91% <14.63%> (-0.09%) ⬇️
versioned-tests-18.x 75.50% <100.00%> (+0.02%) ⬆️
versioned-tests-20.x 75.51% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bizob2828 bizob2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The LlmTool and LlmChatCompletionSummary need an error attribute set to true when an error occurs. Also we can cut a separate PR but it looks like i missed calling out is_response on LlmChatCompletionMessage when the content is the response.

Copy link
Member

@bizob2828 bizob2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can open another PR to capture the is_response on LlmChatCompletionMessage as its unrelated to this PR

@jsumners-nr jsumners-nr merged commit 4d0d839 into newrelic:main Feb 26, 2024
22 checks passed
@jsumners-nr jsumners-nr deleted the issue-1969 branch February 26, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants