Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add missing is_response to LangChain completion messages #2044

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

jsumners-nr
Copy link
Contributor

This PR fixes an oversight from previous work.

Verified

This commit was signed with the committer’s verified signature.
jsumners-nr James Sumners
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.16%. Comparing base (4d0d839) to head (9cf69c2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2044   +/-   ##
=======================================
  Coverage   97.16%   97.16%           
=======================================
  Files         248      248           
  Lines       41648    41655    +7     
=======================================
+ Hits        40466    40473    +7     
  Misses       1182     1182           
Flag Coverage Δ
integration-tests-16.x 78.50% <44.44%> (+<0.01%) ⬆️
integration-tests-18.x 78.46% <44.44%> (-0.02%) ⬇️
integration-tests-20.x 78.48% <44.44%> (+<0.01%) ⬆️
unit-tests-16.x 90.80% <66.66%> (-0.01%) ⬇️
unit-tests-18.x 90.79% <66.66%> (-0.01%) ⬇️
unit-tests-20.x 90.79% <66.66%> (-0.01%) ⬇️
versioned-tests-16.x 74.91% <44.44%> (-0.03%) ⬇️
versioned-tests-18.x 75.50% <100.00%> (-0.02%) ⬇️
versioned-tests-20.x 75.51% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bizob2828 bizob2828 self-assigned this Feb 26, 2024
@jsumners-nr jsumners-nr merged commit 20c7d47 into newrelic:main Feb 26, 2024
24 checks passed
@jsumners-nr jsumners-nr deleted the fix-is_response branch February 26, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants