Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Changed token_count to only use tokenCountCallback #2070

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

jsumners-nr
Copy link
Contributor

This PR resolves #2069.

@jsumners-nr jsumners-nr force-pushed the issue-2069 branch 2 times, most recently from 8ac3781 to 176f400 Compare March 8, 2024 14:29
@jsumners-nr jsumners-nr marked this pull request as ready for review March 8, 2024 14:41
@jsumners-nr jsumners-nr requested a review from bizob2828 March 8, 2024 14:41
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.18%. Comparing base (64b4ca2) to head (19e0a2b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2070   +/-   ##
=======================================
  Coverage   97.18%   97.18%           
=======================================
  Files         248      248           
  Lines       41936    41938    +2     
=======================================
+ Hits        40754    40756    +2     
  Misses       1182     1182           
Flag Coverage Δ
integration-tests-16.x 78.24% <ø> (+0.01%) ⬆️
integration-tests-18.x 78.21% <ø> (ø)
integration-tests-20.x 78.23% <ø> (ø)
unit-tests-16.x 90.49% <100.00%> (+<0.01%) ⬆️
unit-tests-18.x 90.47% <100.00%> (+<0.01%) ⬆️
unit-tests-20.x 90.47% <100.00%> (+<0.01%) ⬆️
versioned-tests-16.x 74.48% <72.72%> (-0.03%) ⬇️
versioned-tests-18.x 75.60% <72.72%> (-0.03%) ⬇️
versioned-tests-20.x 75.61% <72.72%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Verified

This commit was signed with the committer’s verified signature.
bizob2828 Bob Evans

Verified

This commit was signed with the committer’s verified signature.
bizob2828 Bob Evans
@jsumners-nr jsumners-nr requested a review from bizob2828 March 11, 2024 14:53
@jsumners-nr jsumners-nr merged commit 66f94b0 into newrelic:main Mar 11, 2024
22 checks passed
@jsumners-nr jsumners-nr deleted the issue-2069 branch March 11, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Only assign token_count from result of tokenCountCallback
2 participants