feat: Added guid attribute to TransactionError events
#2079
+106
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2079 +/- ##
==========================================
- Coverage 97.18% 97.18% -0.01%
==========================================
Files 248 248
Lines 41938 41937 -1
==========================================
- Hits 40756 40755 -1
Misses 1182 1182
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
svetlanabrennan
changed the title
TransactionError events
svetlanabrennan
changed the title
TransactionError eventsguid attribute to TransactionError events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our agents needs to add
guidtoTransactionErrorevents. This is the final step needed in order for Errors Inbox team to linkTransactionErrorevents andErrorTraceevents when errors happen within a transaction.How to Test
Added unit tests. Also ran a sample errors app and verified in the query builder that there is a
guidonTransactionErrorevents when distributed tracing is enabled or disabled.Distributed tracing enabled - error trace:
Distributed tracing enabled - transaction error:
Distributed tracing disabled - error trace:
Distributed tracing disabled - transaction error:
Related Issues
Relates to this pr #1954
Closes #2076