Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added instrumentation for initializeUnorderedBulkOp, and initializeOrderedBulkOp in mongodb 4+ #2086

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

bizob2828
Copy link
Member

@bizob2828 bizob2828 commented Mar 19, 2024

  • feat: Added support for Mongo v5+
  • feat: Added instrumentation for initializeUnorderedBulkOp

Description

Note: This is based off of my mongo-5 branch so this will need to rebased after #2085 is merged. The relevant commit is this one

I'm not sure what 2022 me was doing but this was rather straightforward. This Pr adds instrumentation for initializeUnorderedBulkOp and initializeOrderedBulkOp.

How to Test

npm run versioned:internal mongodb

Related Issues

Closes #1122

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.21%. Comparing base (07d7e7d) to head (33abd69).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2086   +/-   ##
=======================================
  Coverage   97.21%   97.21%           
=======================================
  Files         251      251           
  Lines       42376    42398   +22     
=======================================
+ Hits        41194    41216   +22     
  Misses       1182     1182           
Flag Coverage Δ
integration-tests-16.x 78.24% <ø> (-0.02%) ⬇️
integration-tests-18.x 78.23% <ø> (+0.01%) ⬆️
integration-tests-20.x 78.22% <ø> (-0.02%) ⬇️
unit-tests-16.x 90.59% <ø> (ø)
unit-tests-18.x 90.57% <ø> (ø)
unit-tests-20.x 90.57% <ø> (ø)
versioned-tests-16.x 74.50% <100.00%> (-0.01%) ⬇️
versioned-tests-18.x 75.62% <100.00%> (-0.01%) ⬇️
versioned-tests-20.x 75.62% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Verified

This commit was signed with the committer’s verified signature.
bizob2828 Bob Evans
…tializeOrderedBulkOp` in mongodb 4+
Copy link
Contributor

@jsumners-nr jsumners-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@bizob2828 bizob2828 merged commit 666ae6e into newrelic:main Mar 20, 2024
22 checks passed
@bizob2828 bizob2828 deleted the bulk-ops branch April 3, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Bulk operation support in mongo v4
2 participants