Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Convert CVSSv2 into CVSSv3 #1204

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WIP] Convert CVSSv2 into CVSSv3 #1204

wants to merge 1 commit into from

Conversation

ziadhany
Copy link
Collaborator

issue : #1187

@ziadhany ziadhany marked this pull request as ready for review May 30, 2023 11:56
@ziadhany
Copy link
Collaborator Author

ziadhany commented May 30, 2023 •
edited

according to my assumption, I tried to find the best way of doing this.
but I am not sure about how accurate the result

Take a look at the result : output.txt

@ziadhany ziadhany force-pushed the convert_cvssv2_to_cvssv3 branch 2 times, most recently from 02e8616 to 9de5457 Compare July 11, 2023 10:51
@ziadhany
Fix missing condition in convert_cvssv2_vector_to_cvssv3_vector function
b0cb62b 
Test function with nvd_cvss.csv data
Remove function from severity_systems.py
Rename file to cvss2to3.py
Add download_url fof severity_systems.py.ABOUT
Fix notes
Test with nvd severity data
Move the cvssv2_converter.py to serverity_systems.py
Give credit to Marc Ruef
Fix missing parts in the vector
Add some tests
Edit CI,  II , AI to C , I,  A
Convert CVSSv2 into CVSSv3

Signed-off-by: ziadhany <ziadhany2016@gmail.com>
@ziadhany
Copy link
Collaborator Author

Test result :

Screenshot from 2023-07-25 16-11-46

@pombredanne
Copy link
Member

@ziadhany re: #1204 (comment)
Does this mean that mosts v2 to v3 tests are failing ... compared to the NVD?

@ziadhany
Copy link
Collaborator Author

ziadhany commented Jul 25, 2023 •
edited

@ziadhany re: #1204 (comment) Does this mean that mosts v2 to v3 tests are failing ... compared to the NVD?

I tried to improve it , the test result was less 10% but after some debugging we got 36.4315898% with a small problems with Base Score Metrics

@TG1999 TG1999 marked this pull request as draft December 12, 2023 17:15
@TG1999 TG1999 changed the title Convert CVSSv2 into CVSSv3 [WIP] Convert CVSSv2 into CVSSv3 Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ziadhany @pombredanne