Feature implement linked commits #1226
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
That's something that was in the plan. Eventually an improver should be able to do anything it likes to do and the initial limitation with some "advisory" needed to be replaced. |
Signed-off-by: JafarAkhondali <jafar.akhoondali@gmail.com>
JafarAkhondali
force-pushed
the
feature-implement-linked-commits
branch
from
5dcb00d
to
9c564db
Compare
|
I've signed the commits, so DCO should be happy now :) |
+ Refactor Improver model to support custom improver + Update Improver documentation Signed-off-by: JafarAkhondali <jafar.akhoondali@gmail.com> Signed-off-by: JafarAkhondali <jafar.akhoondali@gmail.com> Signed-off-by: JafarAkhondali <jafar.akhoondali@gmail.com> Signed-off-by: JafarAkhondali <jafar.akhoondali@gmail.com>
JafarAkhondali
force-pushed
the
feature-implement-linked-commits
branch
from
5f442f0
to
cd115b3
Compare
|
@pombredanne There were some issues with formats, I fixed them and rebased the commits. |
|
@JafarAkhondali please rebase the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, first-time contribution here.
I had to adjust
Improvermodel to support custom improver, as the previous method assumes improvers will return always an advisory data (If I understood correctly).It's also safe to run the command multiple time, as it uses a one-to-one relation with constrain checking.
The
chain_urlsfield might be filled in next PR to record usage of multiple links to reach commit(s).