Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin work on combining affected and fixed by packages #1287 #1320

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

johnmhoran
Copy link
Member

Reference: #1287

Reference: #1287

Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@TG1999
Copy link
Member

TG1999 commented Dec 6, 2023

@johnmhoran is this PR ready for review ?

@johnmhoran
Copy link
Member Author

Thanks for the question @TG1999. No, this draft PR is nowhere close to being ready for review. I started this work on the VCIO Vulnerability UI/API back in October when my Package UI/API PR was ready and awaiting comments, but this work incorporates that work and thus I hit a roadblock early on and stopped because the Package PR lingered for a while. That roadblock is now gone. ;-)

This Vulnerability work also involves the "bad" data issues (e.g., duplicate PURLs), since combining the affected by tab and fixed by tab will currently include all the duplicate PURLs (and might also involve their respective but possibly different vulnerabilities). However, I'm inclined to go ahead despite the data issue and see what the combined affected by/fixed by tabs look like. I expect that for each set of duplicate PURLs we'll have 2 rows, not 1, which might confuse or even put off users but seems unavoidable while the data issue persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants