Add date of publishing on vulnerability #1370
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999
commented
Jan 9, 2024
| from vulnerabilities.importers.nvd import NVDImporter | ||
| nvd_date = None | ||
| date_published = None | ||
| for advisory in self.advisories.all(): |
There was a problem hiding this comment.
Use filter, for created_by = NVD and date_published != None, sort by latest date_collected, to get the latest updates.
| if advisory.created_by == NVDImporter.__qualname__: | ||
| nvd_date = advisory.date_published | ||
| if nvd_date: | ||
| return nvd_date |
There was a problem hiding this comment.
Use isoformat here as well.
| date_published = advisory.date_published | ||
| if advisory.date_published < date_published: | ||
| date_published = advisory.date_published | ||
| return date_published.isoformat() |
There was a problem hiding this comment.
Suggested change
| return date_published.isoformat() | |
| return date_published |
| super().save(*args, **kwargs) | ||
|
|
||
| @property | ||
| def get_date_published(self): |
There was a problem hiding this comment.
Suggested change
| def get_date_published(self): | |
| def find_date_published(self): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.