-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: ui: added progress bar for vulnerabilities.importers
#1378
base: main
Are you sure you want to change the base?
Conversation
@harsh098 thanks! you may need to re-write your commit message, your commit message needs to be imperative, have a look on this https://cbea.ms/git-commit/ |
04d641d
to
9d7c8ad
Compare
I have changed commit message please check @TG1999 also shall i propagate this change to all other importers ? |
@harsh098 the commit message should be
Please do! |
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
9d7c8ad
to
8cee434
Compare
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
vulnerabilities.importers.nvd.NVDImporter
vulnerabilities.importers
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
0af7451
to
57e0e28
Compare
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Progress bar has been added to following Importers
Working on rest of importers |
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
b4839b1
to
33c1533
Compare
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@harsh098 thanks for your effort , final nits for your consideration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future iteration, it would be much better to abstract the progress logging within the ImportRunner().run()
itself so that we don't need to individually log the progress inside each importer.
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
145cb4b
to
d9ea936
Compare
In response to Issue #1376 . I am pushing the changes that add a progress bar to the
vulnerabilitites.importers.nvd.NVDImporter
Dependencies Added
progress==1.6
allows addition of progress bars to tty consoles.Screenshots