Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: ui: added progress bar for vulnerabilities.importers #1378

Open
wants to merge 71 commits into
base: main
Choose a base branch
from

Conversation

harsh098
Copy link
Contributor

In response to Issue #1376 . I am pushing the changes that add a progress bar to the vulnerabilitites.importers.nvd.NVDImporter

  • Please Review and suggest changes/improvements.
  • I'll replicate these changes to all other importers.

Dependencies Added

  • progress==1.6 allows addition of progress bars to tty consoles.

Screenshots

image

@TG1999
Copy link
Member

TG1999 commented Dec 25, 2023

@harsh098 thanks! you may need to re-write your commit message, your commit message needs to be imperative, have a look on this https://cbea.ms/git-commit/

@harsh098
Copy link
Contributor Author

I have changed commit message please check @TG1999 also shall i propagate this change to all other importers ?

@TG1999
Copy link
Member

TG1999 commented Dec 25, 2023

@harsh098 the commit message should be Add progress bar to NVDImporter and not Added progress bar to NVDImporter, commit messages should be imperative like a command given to the codebase.

also shall i propagate this change to all other importers ?

Please do!

Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
@harsh098 harsh098 changed the title feature: ui: added progress bar for vulnerabilities.importers.nvd.NVDImporter feature: ui: added progress bar for vulnerabilities.importers Dec 26, 2023
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
harsh098 and others added 6 commits December 28, 2023 01:10
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
@harsh098
Copy link
Contributor Author

Progress bar has been added to following Importers

  • nvd.NVDImporter
  • github.GitHubAPIImporter
  • gitlab.GitLabAPIImporter
  • npm.NpmImporter
  • pypa.PyPaImporter
  • nginx.NginxImporter
  • pysec.PyPIImporter

Working on rest of importers

Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
harsh098 and others added 10 commits December 30, 2023 04:43
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
harsh098 and others added 10 commits January 3, 2024 06:50
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
@harsh098 harsh098 requested a review from ziadhany January 3, 2024 23:25
@harsh098
Copy link
Contributor Author

harsh098 commented Jan 4, 2024

An important thing to consider,
The recent workflows failed as dependency
progress==1.6
was added to requirements.txt in this commit 8cee434 was not installed by the workflow

@TG1999 and @ziadhany please suggest requisite changes from my end

harsh098 and others added 2 commits January 4, 2024 19:11
@harsh098
Copy link
Contributor Author

harsh098 commented Jan 4, 2024

@TG1999 and @ziadhany
I forgot to add the dependency progress==1.6 to setup.cfg.
Please rerun the checks.
The lastest commit 7f5eb72 fixes this.
I apologise for the carelessness

@ziadhany
Copy link
Collaborator

ziadhany commented Jan 5, 2024

@TG1999 and @ziadhany I forgot to add the dependency progress==1.6 to setup.cfg. Please rerun the checks. The lastest commit 7f5eb72 fixes this. I apologise for the carelessness

No worries about carelessness! We all need a helping hand sometimes

@harsh098
Copy link
Contributor Author

harsh098 commented Jan 5, 2024

Sure @ziadhany ,
As discussed above this PR addresses the issue #1376 ,
Are there any further additions required else I'm ma' movin' to other issues I'm researching on to work ?

Copy link
Collaborator

@ziadhany ziadhany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harsh098 thanks for your effort , final nits for your consideration

vulnerabilities/importers/fireeye.py Outdated Show resolved Hide resolved
vulnerabilities/importers/pypa.py Show resolved Hide resolved
Copy link
Member

@keshav-space keshav-space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future iteration, it would be much better to abstract the progress logging within the ImportRunner().run() itself so that we don't need to individually log the progress inside each importer.

@harsh098
Copy link
Contributor Author

Made the requested changes please have a look @ziadhany and @TG1999

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants