Handle new ProcessGlobalArgsInternal function in node >19 #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebboyd
reviewed
Mar 30, 2024
Co-authored-by: Caleb Boyd <caleb.boyd@gmail.com>
|
@calebboyd could you help get the integration tests to run? |
calebboyd
added a commit
that referenced
this pull request
Apr 29, 2024
* Handle new ProcessGlobalArgsInternal function in node >19 * Use 18.19.99 specifically * Update src/patches/disable-node-cli.ts Co-authored-by: Caleb Boyd <caleb.boyd@gmail.com> --------- Co-authored-by: Caleb Boyd <caleb.boyd@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As of nodejs/node#44746, the function that formerly performed global variable processing changed from
ProcessGlobalArgstoProcessGlobalArgsInternalwith a different return type. This is causing the error seen in #1084 and #1082.Which issue(s) this PR fixes:
Fixes #1082
Fixes #1084
Special notes for your reviewer: