New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(drizzle): webauthn support #10297
feat(drizzle): webauthn support #10297
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
@JipSterk is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
@JipSterk thanks for reopening this! Could you also add some tests for this new model?? See the |
ee83187
to
8ae92ee
Compare
hi @ndom91, could you run the test & verify pipelines to ensure if the code i've written is any good? i couldn't get the test running locally. |
2728050
to
a64b7d4
Compare
@JipSterk it looks like the So I've updated those two issues in all 3 db files ( Hope thats okay!| Tests should be passing now, the docs are updated. Looks pretty good to me! |
@ndom91 Thanks for your review/update any help it has to ship this feature out te happier i would be :) i thought of adding an entry to https://authjs.dev/getting-started/authentication/webauthn for drizzle, perhaps after that as well as all the tests clearing do you feel like we could ship it out? I’m eager to use it in my projects! |
Yeah we'll have to reoganise that and somehow show which frameworks / clients and which database adapters support WebAuthn / Passkeys better But yeah if you don't see any other issues here, neither do I! |
Hmm something seems to be breaking the E2E playwright tests here (GHA) 🤔 It's using the But (1) that dev app isn't touched here and (2) the dev app isn't using drizzle in any way. So I'm a bit confused as to whats going on there.. It says that there's a configuration error 🤔 |
Thanks @ndom91 for resolving & merging this! |
☕️ Reasoning
🧢 Checklist
🎫 Affected issues
📌 Resources