feat(drizzle): webauthn support

[JipSterk]

☕️ Reasoning

🧢 Checklist

• Documentation
• Tests
• Ready to be merged

🎫 Affected issues

📌 Resources

• Security guidelines
• Contributing guidelines
• Code of conduct
• Contributing to Open Source

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
auth-docs	❌ Failed (Inspect)			May 19, 2024 10:43am

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
next-auth-docs	⬜️ Ignored (Inspect)	Visit Preview		May 19, 2024 10:43am

[vercel]

@JipSterk is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

[ndom91]

@JipSterk thanks for reopening this!

Could you also add some tests for this new model?? See the adapter-prisma Authenticator tests for an example 🙏

[JipSterk]

hi @ndom91, could you run the test & verify pipelines to ensure if the code i've written is any good? i couldn't get the test running locally.
And would like to close the pr since i would like to integrate WebAuthn in my application using a drizzle adapter

[ndom91]

@JipSterk it looks like the getAccount method was missing from the 3 DB types and the updateAuthenticatorCounter method is supposed to throw, which it wasn't (even with the return await .. syntax that was there previously 🤔)

So I've updated those two issues in all 3 db files (sqlite.ts, pg.ts, mysql.ts). I also cleaned up a few of the unnecessary return await .. statements.

Hope thats okay!|

Tests should be passing now, the docs are updated. Looks pretty good to me!

[JipSterk]

@ndom91 Thanks for your review/update any help it has to ship this feature out te happier i would be :) i thought of adding an entry to https://authjs.dev/getting-started/authentication/webauthn for drizzle, perhaps after that as well as all the tests clearing do you feel like we could ship it out? I’m eager to use it in my projects!

[ndom91]

@ndom91 Thanks for your review/update any help it has to ship this feature out te happier i would be :) i thought of adding an entry to authjs.dev/getting-started/authentication/webauthn for drizzle, perhaps after that as well as all the tests clearing do you feel like we could ship it out? I’m eager to use it in my projects!

Yeah we'll have to reoganise that and somehow show which frameworks / clients and which database adapters support WebAuthn / Passkeys better

But yeah if you don't see any other issues here, neither do I!

[ndom91]

Hmm something seems to be breaking the E2E playwright tests here (GHA) 🤔

It's using the /apps/dev/nextjs app and playwright traces can be downloaded here.

But (1) that dev app isn't touched here and (2) the dev app isn't using drizzle in any way. So I'm a bit confused as to whats going on there.. It says that there's a configuration error 🤔

[ndom91]

Decided to take a closer look and it definitely passes for me locally, so I think this is good to go!

[JipSterk]

Thanks @ndom91 for resolving & merging this!