fix: Use consistent error type between doc, logger and error class #5046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The same errors have been logged, firstly before throwing OAuthCallbackError, later in the catch-clause of it. This commit removes the former and lets the latter survive, because logging functionality seems better to reside in the same neighborhood.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ThangHuuVu
reviewed
Jul 31, 2022
Co-authored-by: Thang Vu <thvu@hey.com>
|
@ThangHuuVu Thanks for the feedback. How does it look to you now? |
|
@ndom91 @lluia I was wondering if changing the error code requires a bump in semver 🤔 WDYT? |
ThangHuuVu
changed the title
ThangHuuVu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
Following up this comment: #5027 (comment).
I've abstained from further renaming it like
CALLBACK_ERROR, since my original intention is only to make them consistent. I'm feeling happy enough withOAUTH_CALLBACK_ERROR, partly because I am not really sure over the intention of renaming. So I'd like to leave that to you.About the doc, two changes have been made: merging
CALLBACK_OAUTH_ERRORandoauth_callback_error, and relocatingopenid-clientstuff toSIGNIN_OAUTH_ERRORsection. Background of the latter change is reasoned in #5045.Commits are separately made, but if you want me to squash them let me know.
🧢 Checklist
🎫 Affected issues
Closes: #5045
📌 Resources