Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use consistent error type between doc, logger and error class #5046

Merged
merged 5 commits into from Aug 22, 2022
Merged

fix: Use consistent error type between doc, logger and error class #5046

merged 5 commits into from Aug 22, 2022

Commits on Jul 29, 2022

  1. Keep error from being logged twice 

    The same errors have been logged, firstly before throwing
OAuthCallbackError, later in the catch-clause of it.

This commit removes the former and lets the latter survive,
because logging functionality seems better to reside in the
same neighborhood.
    @sato11
    sato11 committed Jul 29, 2022
    Copy the full SHA
    2718ade View commit details
    Browse the repository at this point in the history

  2. doc: Merge CALLBACK_OAUTH_ERROR to OAUTH_CALLBACK_ERROR

    @sato11
    sato11 committed Jul 29, 2022
    Copy the full SHA
    2dd943d View commit details
    Browse the repository at this point in the history

  3. doc: This particular error from openid-client comes with SIGNIN_OAUTH… 

    …_ERROR
    @sato11
    sato11 committed Jul 29, 2022
    Copy the full SHA
    3804fda View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2022

  1. Provide logger with providerId 

    Co-authored-by: Thang Vu <thvu@hey.com>
    @sato11 @ThangHuuVu
    sato11 and ThangHuuVu committed Aug 2, 2022
    Copy the full SHA
    b46284d View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2022

  1. Merge branch 'main' into enhance-error-logs

    @ThangHuuVu
    ThangHuuVu committed Aug 21, 2022
    Copy the full SHA
    5736854 View commit details
    Browse the repository at this point in the history