-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kysely): interface mismatch with default schema and kysely schema rules #10449
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
@AchalS-iglu is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
UPDATE: Still some errors. |
Yeaah,,, I cannot figure it out, I must be doing something wrong, If I type the KyselyAuth to use Schema it breaks the KyselyAdapter |
AYO, don't merge undo it, this will break the existing systems, I will send a new commit fixing a few issues soon @ndom91 I am sorry I am not used to PRs I should've closed this or something |
I have given up on figuring out how to work with modules and packages for now, I tried running tests but it was taking too long. I have chosen to make a custom adapter instead since I have to quickly finish my project. Here is the adapter for reference, I am closing this PR.
|
☕️ Reasoning
The adapter was using core types for verifying database schema. Kysely schema doesn't follow standard typing rules, it uses things like GeneratedAlways, ColumnType, etc.
The new types automatically align with the adapter types thanks to how kysely works.
The Database interface has been replaced with DatabaseSchema interface that is pretty much the same thing.
This is also more in line with the documentation
I had also opened an issue for the same - #10441
🧢 Checklist
🎫 Affected issues
#10441
📌 Resources