Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): fix drizzle docs imports and syntax #10676

Closed
wants to merge 3 commits into from

Conversation

mohit4bug
Copy link

☕️ Reasoning

I've updated the Drizzle adapter guides to fix some import statements and added missing brackets in the content to ensure the code examples are correct and complete.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

No specific issues were addressed by this PR.

📌 Resources

This looks good to go! Once the review is complete, we can proceed with merging the changes. If there are any further adjustments or feedback, feel free to let me know!

Copy link

vercel bot commented Apr 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2024 4:53pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Apr 28, 2024 4:53pm

@ndom91
Copy link
Member

ndom91 commented Apr 21, 2024

I'm going to hold off on this PR for the time being, as there is some active work being done to fix up some things in regard to the recent Drizzle adapter rewrite, see the comments at the bottom of that PR. Also there's some discussion about it in the discord if yuo wanna check it out:

@ndom91 ndom91 changed the title fix: imports & brackets in drizzle docs chore(docs): fix drizzle docs imports and syntax Apr 21, 2024
@ndom91 ndom91 added adapters Changes related to the core code concerning database adapters drizzle @auth/drizzle-adapter and removed next-auth labels Apr 21, 2024
@ndom91 ndom91 self-assigned this Apr 21, 2024
@mohit4bug
Copy link
Author

I'm going to hold off on this PR for the time being, as there is some active work being done to fix up some things in regard to the recent Drizzle adapter rewrite, see the comments at the bottom of that PR. Also there's some discussion about it in the discord if yuo wanna check it out:

Thank you for letting me know!

@ndom91
Copy link
Member

ndom91 commented Apr 28, 2024

Hey we've updated the Drizzle adapter (and docs) a good bit the last few days. Can you check out the merge conflict and see if these changes are still necessary?

Thanks!

@mohit4bug
Copy link
Author

mohit4bug commented Apr 28, 2024

I don't see any issues with it now!

Copy link

vercel bot commented Apr 28, 2024

@mohit4bug is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot removed adapters Changes related to the core code concerning database adapters drizzle @auth/drizzle-adapter labels Apr 28, 2024
@ndom91
Copy link
Member

ndom91 commented Apr 29, 2024

Okay great, I'll close this PR then 🙏

@ndom91 ndom91 closed this Apr 29, 2024
@mohit4bug mohit4bug deleted the code-sample-docs branch April 29, 2024 11:19
@mohit4bug mohit4bug restored the code-sample-docs branch April 29, 2024 11:19
@mohit4bug mohit4bug deleted the code-sample-docs branch April 29, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants