feat(adapter-pg): define foreign keys, use single queries #10733
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
userId
to theid
inusers
with cascading delete. The delete user query can now be a single one due to cascading deletes.id
insessions
is deleted and the primary key replaced withsessionToken
, which needs to be unique anyways. Turning it into the primary key should also speed upWHERE sessionToken
queries.SELECT
thenUPDATE
are now a singleUPDATE
to ensure atomicity. This required creating a rather uglycreateParameterizedUpdate
function to only join togetherkey = $2
if it exists in the passed-in object. I was unable to figure out the right incantation of TypeScript types to makecreateParameterizedUpdate
type-safe but happy to accept any suggestions to fix this.🧢 Checklist
🎫 Affected issues
📌 Resources