New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sveltekit): update sveltekit eslint tooling #10748
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10748 +/- ##
=======================================
Coverage 41.12% 41.12%
=======================================
Files 173 173
Lines 28472 28472
Branches 1179 1179
=======================================
Hits 11710 11710
Misses 16762 16762 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also remove next-auth/packages/frameworks-sveltekit/.eslintrc.cjs
, I think its not used right
Co-authored-by: Thang Vu <hi@thvu.dev>
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Yeah I think you're right. I've removed them 👍 |
@ndom91 there is still one issue in the build, shall we fix it here too? |
@ThangHuuVu yeah good eye - just ran prettier on it and pushed. Lets see |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@sveltejs/adapter-auto@3.2.0, npm/@sveltejs/kit@2.5.7, npm/@sveltejs/vite-plugin-svelte@3.1.0, npm/svelte-check@3.6.9, npm/svelte@4.2.15, npm/typescript@5.4.5, npm/vite@5.2.10 |
☕️ Reasoning
eslint-plugin-svelte3
toeslint-plugin-svelte
(Source)dist
output folder toclean
npm script inframework-sveltekit
I'd love someone with VSCode to test this as well though, looks good to me in nvim and build output is the same too
🧢 Checklist
🎫 Affected issues
📌 Resources