Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(license): ensure all packages have "ISC" license #10749

Merged
merged 3 commits into from Apr 29, 2024

Conversation

ndom91
Copy link
Member

@ndom91 ndom91 commented Apr 28, 2024

☕️ Reasoning

  • Noticed that @auth/sveltekit didn't list a licence on npm
  • Ensured everyone has ISC listed in package.json and docs is relicensed from Shu's Nextra's MIT to match our ISC (MIT explicitly allows "sublicensing")
    • This is less important, we can drop this if anyone cares 👍

image

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

Copy link

vercel bot commented Apr 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 11:17am
proxy ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 11:17am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Apr 29, 2024 11:17am

Copy link

socket-security bot commented Apr 28, 2024

Copy link

Broken Link Checker

0 broken links found. Links organised below by source page, or page where they were found.

Copy link

codecov bot commented Apr 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.46%. Comparing base (42ecf79) to head (aecc099).
Report is 1 commits behind head on main.

❗ Current head aecc099 differs from pull request most recent head 1832c01. Consider uploading reports for the commit 1832c01 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10749   +/-   ##
=======================================
  Coverage   41.46%   41.46%           
=======================================
  Files         172      172           
  Lines       28236    28236           
  Branches     1171     1171           
=======================================
  Hits        11709    11709           
  Misses      16527    16527           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Potential typo squat npm/esbuild-plugin-solid@0.5.0
  • orphan: npm/esbuild-plugin-solid@0.5.0

View full report↗︎

Next steps

What is a typosquat?

Package name is similar to other popular packages and may not be the package you want.

Use care when consuming similarly named packages and ensure that you did not intend to consume a different package. Malicious packages often publish using similar names as existing popular packages.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/esbuild-plugin-solid@0.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants