Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): support trailingSlash in providerAndAccountId parsing #10752

Merged
merged 5 commits into from Apr 29, 2024

Conversation

ndom91
Copy link
Member

@ndom91 ndom91 commented Apr 28, 2024

☕️ Reasoning

  • Support action / providerId paths with trailingSlash enabled (i.e. /api/auth/callback/google/)
  • Add three tests, one with default basePath one with custom basePath and one with edge-case multiple trailingSlashes

Fixes #10127

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

Copy link

vercel bot commented Apr 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 11:11am
proxy ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 11:11am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Apr 29, 2024 11:11am

@github-actions github-actions bot added the core Refers to `@auth/core` label Apr 28, 2024
Copy link

codecov bot commented Apr 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.46%. Comparing base (42ecf79) to head (1e8acb3).

❗ Current head 1e8acb3 differs from pull request most recent head 01408bf. Consider uploading reports for the commit 01408bf to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10752   +/-   ##
=======================================
  Coverage   41.46%   41.46%           
=======================================
  Files         172      172           
  Lines       28236    28236           
  Branches     1171     1171           
=======================================
  Hits        11709    11709           
  Misses      16527    16527           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndom91 ndom91 merged commit 46f9582 into main Apr 29, 2024
7 of 10 checks passed
@ndom91 ndom91 deleted the ndom91/core-support-trailingSlash branch April 29, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trailingSlash does not work in next-auth@v5
2 participants