Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(next-auth): allow react@19 to peer deps #10882

Merged
merged 2 commits into from May 16, 2024

Conversation

devjiwonchoi
Copy link
Contributor

☕️ Reasoning

next@canary peerDeps have React19, so add them.

└─┬ next-auth 4.24.7
  ├── ✕ unmet peer react@"^17.0.2 || ^18": found 19.0.0-beta-4508873393-20240430
  └── ✕ unmet peer react-dom@"^17.0.2 || ^18": found 19.0.0-beta-4508873393-20240430

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

Copy link

vercel bot commented May 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 7:29pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 7:29pm

Copy link

vercel bot commented May 11, 2024

@devjiwonchoi is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@ndom91 ndom91 changed the title chore: add react peer deps 19 chore(next-auth): allow react@19 to peer deps May 12, 2024
@@ -84,7 +84,7 @@
"@simplewebauthn/server": "^9.0.2",
"next": "^14",
"nodemailer": "^6.6.5",
"react": "^18.2.0"
"react": "^18.2.0 || ^19.0.0-0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should cover more 19.x things for now and in the future

Suggested change
"react": "^18.2.0 || ^19.0.0-0"
"react": "^18.2.0 || ^19"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK caret-only ^ doesn't cover the pre-release as well, it had to be set explicitly with -.

x-ref: https://semver.npmjs.com

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay, makes sense. Thanks for the npm semver calc link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reviewing!

@devjiwonchoi devjiwonchoi requested a review from ndom91 May 12, 2024 16:53
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.39%. Comparing base (4ab5f71) to head (d3c25fa).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10882   +/-   ##
=======================================
  Coverage   38.39%   38.39%           
=======================================
  Files         176      176           
  Lines       27454    27454           
  Branches     1212     1212           
=======================================
  Hits        10541    10541           
  Misses      16913    16913           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndom91 ndom91 changed the title chore(next-auth): allow react@19 to peer deps fix(next-auth): allow react@19 to peer deps May 16, 2024
@ndom91 ndom91 merged commit bb10a3c into nextauthjs:main May 16, 2024
13 of 15 checks passed
@devjiwonchoi devjiwonchoi deleted the react-peer-deps-19 branch May 16, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants