Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Postgres port / add document for CockroachDB #1113

Closed
wants to merge 11 commits into from

Conversation

jukbot
Copy link
Contributor

@jukbot jukbot commented Jan 15, 2021

What:

Improve a document, add a guide for CockroachDB who using self-sign cert or any certs.

Why:

I've found that using connection string with sslmode is not working and make the connection manager broken.
So I change the config to TypeORM object format ref from https://typeorm.io/#/connection-options/postgres--cockroachdb-connection-options

Which it work as usual. So I've investigate the cause it was an issue when parsing connection URI with query params reference from
typeorm/typeorm#6544
typeorm/typeorm#6389

And have been fixed in release >= 0.2.26 typeorm/typeorm#6390

EDITED:
This issue has been fixed in #1093

Checklist:

  • Documentation
  • Tests N/A
  • Ready to be merged

@vercel
Copy link

vercel bot commented Jan 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/next-auth/qlsi0eddt
✅ Preview: https://next-auth-git-fork-jukbot-patch-1.nextauthjs.vercel.app

@vercel vercel bot temporarily deployed to Preview January 15, 2021 09:28 Inactive
@jukbot jukbot changed the title fixed Postgres port / add document for CockroachDB fix: Postgres port / add document for CockroachDB Jan 15, 2021
@balazsorban44 balazsorban44 changed the base branch from main to canary January 15, 2021 15:48
@balazsorban44 balazsorban44 added documentation Relates to documentation databases labels Jan 15, 2021
@balazsorban44
Copy link
Member

Added in 0e20b60, thanks @jukbot, added you as a co-author for the commit 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Relates to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants