New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix builds/tests/eslint #4780
Merged
Merged
Changes from 12 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
ed42195
chore(deps): upgrade `typescript`
balazsorban44 81ff0fd
chore(ts): don't exclude test files in tsconfig
balazsorban44 2a60c6f
test: expect error when overriding `NODE_ENV`
balazsorban44 8fc43e1
chore: remove unused import
balazsorban44 292e529
format
balazsorban44 4bab688
chore: use pnpm@7 in action
balazsorban44 e9566d4
chore: fix eslint
balazsorban44 12f7dde
chore: remove pnpm from engines
balazsorban44 4b4066e
chore: fix configs/builds
balazsorban44 418de3f
fix: make eslint works
ThangHuuVu 7b0549e
Merge branch 'main' into chore/add-tests
thang-vu-20230331 f5f5892
Update pnpm-lock.yaml
ThangHuuVu c92332f
fix: build failure
ThangHuuVu ac677dd
fix: add react to paths
ThangHuuVu c6a2870
ignore upstash for now
ThangHuuVu e81ec43
add eslintignore, add a bunch of tsconfig.eslint.json
ThangHuuVu 050c825
ignore mikro orm for now
ThangHuuVu e110836
Delete tsconfig.eslint.json
ThangHuuVu 3e29da3
Update package.json
ThangHuuVu 446436e
Merge branch 'main' into chore/add-tests
ThangHuuVu 7e15ece
Update pnpm-lock.yaml
ThangHuuVu 8a71d59
move eslint back to package.json
ThangHuuVu fa9e6ce
move eslintrc.js out
ThangHuuVu File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
const path = require('path') | ||
|
||
module.exports = { | ||
root: true, | ||
parser: "@typescript-eslint/parser", | ||
parserOptions: { | ||
project: [ | ||
path.resolve(__dirname, './packages/next-auth/tsconfig.json'), | ||
path.resolve(__dirname, 'tsconfig.json') | ||
], | ||
tsconfigRootDir: __dirname | ||
}, | ||
extends: [ | ||
"standard-with-typescript", | ||
"prettier" | ||
], | ||
globals: { | ||
localStorage: "readonly", | ||
location: "readonly", | ||
fetch: "readonly" | ||
}, | ||
rules: { | ||
"camelcase": "off", | ||
"@typescript-eslint/naming-convention": "off", | ||
"@typescript-eslint/strict-boolean-expressions": "off", | ||
"@typescript-eslint/explicit-function-return-type": "off", | ||
"@typescript-eslint/restrict-template-expressions": "off" | ||
}, | ||
plugins: ['jest'], | ||
"env": { | ||
"jest/globals": true | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
{ | ||
"extends": "./tsconfig.json", | ||
"exclude": [ | ||
"./*.js", | ||
"./*.d.ts", | ||
"./config", | ||
"./tests", | ||
"./**/__test__" | ||
] | ||
} |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
{ | ||
"private": true, | ||
"name": "@next-auth/tsconfig", | ||
"private": true, | ||
"version": "0.0.0", | ||
"license": "MIT", | ||
"main": "index.js", | ||
"files": [ | ||
"adapters.json", | ||
"base.json" | ||
"tsconfig.adapters.json", | ||
"tsconfig.base.json", | ||
"tsconfig.eslint.json" | ||
] | ||
} |
4 changes: 2 additions & 2 deletions
4
packages/tsconfig/adapters.json → packages/tsconfig/tsconfig.adapters.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
{ | ||
"extends": "./base.json", | ||
"extends": "./tsconfig.base.json", | ||
"compilerOptions": { | ||
"target": "ES2019", | ||
"module": "commonjs", | ||
"strict": true | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved eslint config to here to use the
path.resolve
inparserOptions.project