Update Strava Provider #5241
Merged
Update Strava Provider #5241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelangeloio
requested review from
ThangHuuVu,
ubbe-xyz and
ndom91
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
michaelangeloio
commented
Aug 28, 2022
michaelangeloio
commented
Aug 28, 2022
ubbe-xyz
requested changes
Aug 30, 2022
Co-authored-by: Lluis Agusti <hi@llu.lu>
|
@lluia Made the changes, let me know if you see anything else! Thank you! |
ubbe-xyz
requested changes
Sep 2, 2022
Hopefully that looks better! |
|
Realized I accidentally included a lock file 😅 , it should be ready now |
ubbe-xyz
approved these changes
Sep 5, 2022
| @@ -13,7 +13,7 @@ The **Strava Provider** comes with a set of default options: | |||
|
|
|||
| - [Strava Provider options](https://github.com/nextauthjs/next-auth/blob/main/src/providers/strava.js) | |||
|
|
|||
| You can override any of the options to suit your own use case. | |||
| You can override any of the options to suit your own use case. Ensure the `redirect_uri` configuration fits your needs accordingly. | |||
There was a problem hiding this comment.
@michaelangrivera my bad, but this was actually done in the wrong file! This is the v3 (unmaintained) documentation. Could you apply this change here in a follow-up PR: https://github.com/nextauthjs/next-auth/blob/main/docs/docs/providers/strava.md
There was a problem hiding this comment.
@balazsorban44 FYI #5299
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
Hi team at NextAuth! First off, I love your work here. It's helped expedite the dev process immensely, so kudos to your team. I've been working on a Strava application that utilizes your
Stravaprovider, and found one potential issue and wanted to contribute some other improvements.Be sure to check the comments/changed files for the specific callouts I'm making.
🧢 Checklist
🎫 Affected issues
Currently,
localhost:3000is hardcoded for theredirect_uriparameter in the provider authorization configuration forstrava.js. If you're blindly following the docs (which I admit I did), you'll likely run into a callback issue when deploying on Vercel (or any other hosting service).Fixes: No issue opened, but happy to open an issue.
📌 Resources