Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(adapters): autogenerate user id in the kysely adapter #9356

Merged
merged 3 commits into from
Dec 10, 2023
Merged

fix(adapters): autogenerate user id in the kysely adapter #9356

merged 3 commits into from
Dec 10, 2023

Conversation

Schniz
Copy link
Contributor

@Schniz Schniz commented Dec 9, 2023

NOTE:

  • It's a good idea to open an issue first to discuss potential changes.
  • Please make sure that you are NOT opening a PR to fix a potential security vulnerability. Instead, please follow the Security guidelines to disclose the issue to us confidentially.

☕️ Reasoning

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

Please scout and link issues that might be solved by this PR.

Fixes: INSERT_ISSUE_LINK_HERE

📌 Resources

@Schniz Schniz requested a review from ndom91 as a code owner December 9, 2023 19:53
@vercel Vercel
Copy link

vercel bot commented Dec 9, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2023 2:46am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
auth-docs-nextra ⬜️ Ignored (Inspect) Visit Preview Dec 10, 2023 2:46am
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Dec 10, 2023 2:46am

@vercel Vercel
Copy link

vercel bot commented Dec 9, 2023

@Schniz is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added adapters Changes related to the core code concerning database adapters kysely labels Dec 9, 2023
@balazsorban44 balazsorban44 changed the title fix: kysely-adapter: autogenerate id in the kysely adapter fix(adapters): autogenerate id in the kysely adapter where needed Dec 10, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 10, 2023
View reviewed changes
packages/adapter-kysely/tests/index.test.ts Dismissed Show dismissed Hide dismissed
packages/adapter-kysely/tests/index.test.ts Dismissed Show dismissed Hide dismissed
packages/adapter-kysely/tests/index.test.ts Dismissed Show dismissed Hide dismissed
@balazsorban44 balazsorban44 changed the title fix(adapters): autogenerate id in the kysely adapter where needed fix(adapters): autogenerate user id in the kysely adapter Dec 10, 2023
@balazsorban44 balazsorban44 merged commit 9122955 into nextauthjs:main Dec 10, 2023
12 of 13 checks passed
@AchalS-iglu
Copy link

AchalS-iglu commented Mar 31, 2024 •
edited

Why did we switch to using those core Adapter types? I am not able to type the Database interface. Look at #10441, could you guide me on how to properly implement it. I am using the same schema mentioned in the docs.

I think you should use standard schema style for verifying schema, that was being used and Selectable<T> for everything else. I will try something I suppose.

@AchalS-iglu
Copy link

AchalS-iglu commented Mar 31, 2024 •
edited

I will test it in my app and get back to you! It did fix my typing errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndom91 ndom91 Awaiting requested review from ndom91 ndom91 is a code owner

@ubbe-xyz ubbe-xyz Awaiting requested review from ubbe-xyz ubbe-xyz is a code owner

Assignees
No one assigned
Labels
adapters Changes related to the core code concerning database adapters kysely
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Schniz @AchalS-iglu @balazsorban44