Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FilePicker): Adjust color of placeholder skeletons #880

Merged
merged 1 commit into from Aug 10, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 10, 2023

Adjust color as suggested by @jancborchardt (I can somehow not request a review from you using GH, but feedback is very welcome 馃槈 ).

I changed the background to

background: linear-gradient(to right,var(--color-background-darker),var(--color-text-maxcontrast),var(--color-background-darker));
background-size: 600px 100%;
border-radius: var(--border-radius);
animation: gradient 12s ease infinite;

Screenshots

before after
image image

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Copy link

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! Is there already a component for this btw or some specific variables? If not it would be good to aligncc @skjnldsv @raimund-schluessler

@AndyScherzinger AndyScherzinger added this to the 4.2.0 milestone Aug 10, 2023
@susnux susnux merged commit 2c0a86d into master Aug 10, 2023
6 checks passed
@susnux susnux deleted the fix/filepicker-skeletons branch August 10, 2023 16:41
@susnux
Copy link
Contributor Author

susnux commented Aug 10, 2023

@jancborchardt I do not think there is a component for this, not sure if it makes sense as it depends on your real content. Maybe just provide the color / background animation of the skeletons as a variable. But maybe someone has an idea how a flexible component can be created for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants