Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FilePicker): The table height should be max. 100% #921

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 23, 2023

If the height is set to 100% the rows are resized and look weird.

Screenshots

before after
image image

…his leads to oversized table rows

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm from the screemshot

@susnux susnux merged commit 8690081 into master Aug 23, 2023
8 checks passed
@susnux susnux deleted the fix/filepicker-table-size branch August 23, 2023 08:51
@skjnldsv skjnldsv mentioned this pull request Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants