Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable4] Center heading of dialog #967

Merged
merged 2 commits into from Aug 28, 2023
Merged

[stable4] Center heading of dialog #967

merged 2 commits into from Aug 28, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 28, 2023

Stable4 version of #965

@susnux
fix(NcDialog): Make the heading always center aligned on top
3b79523 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix: Typo in style rule should be a class not element selector
92c6ebf 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug Something isn't working 3. to review 🍁 2023-Autumn labels Aug 28, 2023
@susnux susnux added this to the 4.2.0 milestone Aug 28, 2023
szaimen
szaimen approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@susnux susnux merged commit ada8f23 into stable4 Aug 28, 2023
6 checks passed
@susnux susnux deleted the fix/stable4-heading branch August 28, 2023 18:35
@Pytal Pytal mentioned this pull request Sep 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review bug Something isn't working
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@susnux @szaimen