Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable4] Fix styling issues and make the FilePicker height fixed #972

Merged
merged 3 commits into from Sep 5, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 28, 2023

* Make sure scrolled elements can not be seen through the table header
* Ensure the buttons are not overlaying the files list content

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…g skeletons

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Copy link

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as per #971 but can not judge the code.

@jancborchardt
Copy link

@AndyScherzinger @skjnldsv if this is not merged, won't we have a wonky file picker which changes height on navigation?

@szaimen
Copy link
Contributor

szaimen commented Sep 4, 2023

/l10n-update

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@Pytal Pytal merged commit 3003a2c into stable4 Sep 5, 2023
6 checks passed
@Pytal Pytal deleted the fix/stable4-design-height branch September 5, 2023 16:43
@Pytal Pytal mentioned this pull request Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants