fix: headers and actions empty variable init

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
nextcloud-libraries · Aug 11, 2023 · 9c850ab · 9c850ab
1 parent f50ab15
commit 9c850ab
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 7 deletions.
diff --git a/__tests__/fileAction.spec.ts b/__tests__/fileAction.spec.ts
@@ -14,9 +14,9 @@ describe('FileActions init', () => {
 	test('Getting empty uninitialized FileActions', () => {
 		logger.debug = vi.fn()
 		const fileActions = getFileActions()
-		expect(window._nc_fileactions).toBeUndefined()
+		expect(window._nc_fileactions).toBeDefined()
 		expect(fileActions).toHaveLength(0)
-		expect(logger.debug).toHaveBeenCalledTimes(0)
+		expect(logger.debug).toHaveBeenCalledTimes(1)
 	})
 
 	test('Initializing FileActions', () => {

diff --git a/__tests__/fileListHeaders.spec.ts b/__tests__/fileListHeaders.spec.ts
@@ -12,9 +12,9 @@ describe('FileListHeader init', () => {
 	test('Getting empty uninitialized FileListHeader', () => {
 		logger.debug = vi.fn()
 		const headers = getFileListHeaders()
-		expect(window._nc_filelistheader).toBeUndefined()
+		expect(window._nc_filelistheader).toBeDefined()
 		expect(headers).toHaveLength(0)
-		expect(logger.debug).toHaveBeenCalledTimes(0)
+		expect(logger.debug).toHaveBeenCalledTimes(1)
 	})
 
 	test('Initializing FileListHeader', () => {

diff --git a/lib/fileAction.ts b/lib/fileAction.ts
@@ -171,5 +171,10 @@ export const registerFileAction = function(action: FileAction): void {
 }
 
 export const getFileActions = function(): FileAction[] {
-	return window._nc_fileactions || []
+	if (typeof window._nc_fileactions === 'undefined') {
+		window._nc_fileactions = []
+		logger.debug('FileActions initialized')
+	}
+
+	return window._nc_fileactions
 }
diff --git a/lib/fileListHeaders.ts b/lib/fileListHeaders.ts
@@ -92,7 +92,7 @@ export class Header {
 export const registerFileListHeaders = function(header: Header): void {
 	if (typeof window._nc_filelistheader === 'undefined') {
 		window._nc_filelistheader = []
-		logger.debug('FileActions initialized')
+		logger.debug('FileListHeaders initialized')
 	}
 
 	// Check duplicates
@@ -105,5 +105,10 @@ export const registerFileListHeaders = function(header: Header): void {
 }
 
 export const getFileListHeaders = function(): Header[] {
-	return window._nc_filelistheader || []
+	if (typeof window._nc_filelistheader === 'undefined') {
+		window._nc_filelistheader = []
+		logger.debug('FileListHeaders initialized')
+	}
+
+	return window._nc_filelistheader
 }