Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate Navigation and update FileAction from server #732

Merged
merged 4 commits into from Aug 18, 2023

Conversation

skjnldsv
Copy link
Contributor

No description provided.

@codecov

This comment was marked as resolved.

@skjnldsv skjnldsv changed the title feat: migrate Navigation from server feat: migrate Navigation and update FileAction from server Aug 18, 2023
@skjnldsv skjnldsv self-assigned this Aug 18, 2023
@skjnldsv skjnldsv force-pushed the feat/new-menu-context branch 2 times, most recently from e154887 to ce9f36c Compare August 18, 2023 09:24
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add tests at least in a follow up but overall this looks good :)

lib/fileAction.ts Outdated Show resolved Hide resolved
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv merged commit cd35f80 into master Aug 18, 2023
8 of 10 checks passed
@skjnldsv skjnldsv deleted the feat/new-menu-context branch August 18, 2023 14:32
@skjnldsv skjnldsv mentioned this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants