Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getNewFileMenuEntries usage #734

Merged
merged 2 commits into from Aug 22, 2023
Merged

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Aug 18, 2023

A few properties can be updated for a View.
I added the one that seemend to make sense and what we've been doing on server

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv self-assigned this Aug 18, 2023
@skjnldsv skjnldsv requested a review from susnux August 18, 2023 18:01
@skjnldsv skjnldsv added bug Something isn't working 3. to review labels Aug 18, 2023
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #734 (e7cd5e3) into master (352b639) will decrease coverage by 0.80%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #734      +/-   ##
==========================================
- Coverage   77.94%   77.15%   -0.80%     
==========================================
  Files          17       17              
  Lines         390      394       +4     
  Branches      107      107              
==========================================
  Hits          304      304              
- Misses         73       77       +4     
  Partials       13       13              
Files Changed Coverage Δ
lib/navigation/view.ts 8.16% <0.00%> (-0.73%) ⬇️
lib/index.ts 100.00% <100.00%> (ø)

@skjnldsv skjnldsv merged commit 856a665 into master Aug 22, 2023
8 of 10 checks passed
@skjnldsv skjnldsv deleted the fix/getNewFileMenuEntries branch August 22, 2023 13:50
@skjnldsv skjnldsv mentioned this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant