fix: force bundle is-svg

[skjnldsv]

Increase the size a bit, but it's the only solution I've found 😞

[codecov]

Codecov Report

Merging #740 (5b87bb9) into master (82e5420) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #740   +/-   ##
=======================================
  Coverage   77.15%   77.15%           
=======================================
  Files          17       17           
  Lines         394      394           
  Branches      107      107           
=======================================
  Hits          304      304           
  Misses         77       77           
  Partials       13       13           

[susnux]

But we have some pure ESM packages, if you add them to the jest transform it should work? (see nextcloud-vue there are a lot of pure ESM dependencies).

[skjnldsv]

Try it yourself, I tried for hours, 😢
Adding to the jest transform have no effect on server, I don't understand why

[susnux]

Because bundling dependencies here for just jest is a anti pattern I think.
Maybe just import it like import('is-svg').default which work also for commonjs?

[susnux]

I would prefer not bundling and instead dynamically importing it, but 🤷

[skjnldsv]

I would prefer not bundling and instead dynamically importing it, but 🤷

Tried it too, can't dynamically import in a class (async issues) or at the root of the file.
Both fails. If you have any better solution, I'm up for it, that's all I could find, and I'm not super happy about it either :(

[susnux]

Then the only other solution I can think of at the moment would be to only bundle for CJS, but not sure if this is possible. So lets stick with this for the moment.

(wanted to submit, but: Maybe it works if we also drop CJS support. This way the using libraries and apps have to handle it as ESM so there will be no require('is-svg') issue. But not sure if this has any sideeffects, so just an idea.)