Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(files): add node status #744

Merged
merged 1 commit into from Aug 25, 2023
Merged

feat(files): add node status #744

merged 1 commit into from Aug 25, 2023

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Aug 25, 2023

/** This is a new node and it doesn't exists on the filesystem yet */
NEW = 'new',
/** This node has failed and is unavailable  */
FAILED = 'failed',
/** This node is currently loading or have an operation in progress */
LOADING = 'loading',
/** This node is locked and cannot be modified */
LOCKED = 'locked',

Makes it a bit more official instead of those weird hidden values
e.g https://github.com/nextcloud/server/blob/4e60b3c61e8e0699e341fb62f9f109d2525be5ab/apps/files/src/services/Files.ts#L65

@skjnldsv skjnldsv added enhancement New feature or request 3. to review labels Aug 25, 2023
@skjnldsv skjnldsv self-assigned this Aug 25, 2023
@skjnldsv skjnldsv force-pushed the feat/status branch 3 times, most recently from b26142c to 0e2754d Compare August 25, 2023 08:12
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #744 (0e2754d) into master (af661f9) will increase coverage by 0.25%.
The diff coverage is 88.88%.

❗ Current head 0e2754d differs from pull request most recent head 55a2d9b. Consider uploading reports for the commit 55a2d9b to get more accurate results

@@            Coverage Diff             @@
##           master     #744      +/-   ##
==========================================
+ Coverage   77.41%   77.66%   +0.25%     
==========================================
  Files          17       17              
  Lines         394      403       +9     
  Branches      107      108       +1     
==========================================
+ Hits          305      313       +8     
- Misses         76       77       +1     
  Partials       13       13              
Files Changed Coverage Δ
lib/files/node.ts 98.27% <85.71%> (-1.73%) ⬇️
lib/files/nodeData.ts 100.00% <100.00%> (ø)

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@skjnldsv skjnldsv merged commit 5721446 into master Aug 25, 2023
8 checks passed
@skjnldsv skjnldsv deleted the feat/status branch August 25, 2023 11:42
@skjnldsv skjnldsv mentioned this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants