Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide fileList names as newFileMenu handler argument #752

Merged
merged 1 commit into from Aug 29, 2023

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Aug 29, 2023

And fix testing

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv self-assigned this Aug 29, 2023
@skjnldsv skjnldsv added enhancement New feature or request 3. to review labels Aug 29, 2023
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #752 (137bc2d) into master (89d0902) will decrease coverage by 0.75%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #752      +/-   ##
==========================================
- Coverage   77.91%   77.17%   -0.75%     
==========================================
  Files          17       17              
  Lines         403      403              
  Branches      108      108              
==========================================
- Hits          314      311       -3     
- Misses         76       91      +15     
+ Partials       13        1      -12     
Files Changed Coverage Δ
lib/newFileMenu.ts 97.05% <ø> (ø)

... and 1 file with indirect coverage changes

@skjnldsv skjnldsv merged commit 9f8fde3 into master Aug 29, 2023
9 of 10 checks passed
@skjnldsv skjnldsv deleted the feat/namelist branch August 29, 2023 09:49
@skjnldsv skjnldsv mentioned this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants