Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support new file menu entry order #781

Merged
merged 1 commit into from Oct 11, 2023
Merged

feat: support new file menu entry order #781

merged 1 commit into from Oct 11, 2023

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Sep 29, 2023

  • templateName is not used as the file creation is now handled by the developers themselves
  • Renamed if to enabled to match other APIs
  • To ensure we can have a custom order, I also added an order key
Before After with custom order
image image

@skjnldsv
Copy link
Contributor Author

Ping! Please approve @susnux @juliushaertl

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #781 (732f49c) into master (999d5d0) will decrease coverage by 0.19%.
The diff coverage is 81.81%.

❗ Current head 732f49c differs from pull request most recent head 37c3c61. Consider uploading reports for the commit 37c3c61 to get more accurate results

@@            Coverage Diff             @@
##           master     #781      +/-   ##
==========================================
- Coverage   77.80%   77.61%   -0.19%     
==========================================
  Files          17       17              
  Lines         419      420       +1     
  Branches      111      111              
==========================================
  Hits          326      326              
- Misses         92       93       +1     
  Partials        1        1              
Files Coverage Δ
lib/newFileMenu.ts 100.00% <100.00%> (+2.94%) ⬆️
lib/index.ts 83.33% <50.00%> (-16.67%) ⬇️

… remove unused `templateName`

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv merged commit cc0e5e5 into master Oct 11, 2023
8 checks passed
@skjnldsv skjnldsv deleted the fix/newfilemenu branch October 11, 2023 07:04
@skjnldsv skjnldsv mentioned this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants