feat: simplify destination handling #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #912 +/- ##
==========================================
+ Coverage 33.50% 34.89% +1.39%
==========================================
Files 6 6
Lines 200 192 -8
Branches 31 26 -5
==========================================
Hits 67 67
+ Misses 131 123 -8
Partials 2 2
|
2 tasks
skjnldsv
force-pushed
the
feat/simplify-destination
branch
from
ad2ac74
to
e783033
Compare
|
Pushed and fixed tests |
skjnldsv
force-pushed
the
feat/simplify-destination
branch
4 times, most recently
from
837aaae
to
cc0b486
Compare
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
feat/simplify-destination
branch
from
cc0b486
to
0517a84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using strings, let's require a
Folderdirectly and deduct the data from itRequire a new
@nextcloud/filesrelease with nextcloud-libraries/nextcloud-files#731