Skip to content

Commit

Permalink
Add aria-expanded to settings accordion button
Browse files Browse the repository at this point in the history
Mark settings button that triggers the expand/collaps of the
side nav settings with aria-expanded attribute to improve accesibility.

Resolves : nextcloud/server#37136

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
  • Loading branch information
Fenn-CS committed May 13, 2023
1 parent 2d6245a commit 223d38d
Showing 1 changed file with 4 additions and 1 deletion.
Expand Up @@ -27,7 +27,10 @@
<div id="app-settings__header">
<button class="settings-button"
type="button"
@click="toggleMenu">
@click="toggleMenu"
:aria-expanded="open"

Check warning on line 31 in src/components/NcAppNavigationSettings/NcAppNavigationSettings.vue

View workflow job for this annotation

GitHub Actions / eslint

Attribute ":aria-expanded" should go before "@click"
aria-controls="app-settings__content"

Check warning on line 32 in src/components/NcAppNavigationSettings/NcAppNavigationSettings.vue

View workflow job for this annotation

GitHub Actions / eslint

Attribute "aria-controls" should go before "@click"
aria-label="Open settings menu">

Check warning on line 33 in src/components/NcAppNavigationSettings/NcAppNavigationSettings.vue

View workflow job for this annotation

GitHub Actions / eslint

Attribute "aria-label" should go before "@click"
<Cog class="settings-button__icon" :size="20" />
<span class="settings-button__label">{{ title }}</span>
</button>
Expand Down

0 comments on commit 223d38d

Please sign in to comment.