Skip to content

Commit

Permalink
Merge pull request #4946 from nextcloud-libraries/fix/NcActions--prov…
Browse files Browse the repository at this point in the history
…ide-aria-expanded-false

fix(NcActions): provide `aria-expanded="false"` when menu is closed instead of removing it
  • Loading branch information
ShGKme committed Dec 12, 2023
2 parents 93c5a29 + 9408082 commit ebbe5c6
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/components/NcActions/NcActions.vue
Original file line number Diff line number Diff line change
Expand Up @@ -1384,8 +1384,7 @@ export default {
'aria-haspopup': this.isSemanticMenu ? 'menu' : null,
'aria-label': this.menuName ? null : this.ariaLabel,
'aria-controls': this.opened ? this.randomId : null,
// Do not add aria-expanded="true" when it is closed
'aria-expanded': this.opened ? 'true' : undefined,
'aria-expanded': this.opened ? 'true' : 'false',
},
on: {
focus: this.onFocus,
Expand Down

0 comments on commit ebbe5c6

Please sign in to comment.