Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NcPopover: Fix setReturnFocus property #3761

Merged
merged 1 commit into from Feb 17, 2023
Merged

NcPopover: Fix setReturnFocus property #3761

merged 1 commit into from Feb 17, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Feb 15, 2023

Fixed the wrong JSDoc comment :

Syntax error in type: import('focus-trap').Options['setReturnFocus'] eslint jsdoc/valid-types

Also added a default value to make eslint happy (even if undefined) and added the missing type information:

Prop 'setReturnFocus' requires default value to be set. eslint: vue/require-default-prop
Prop "setReturnFocus" should define at least its type. eslint: vue/require-prop-types

@susnux susnux added bug Something isn't working 3. to review Waiting for reviews feature: popover Related to the popovermenu component labels Feb 15, 2023
@Pytal
Copy link
Contributor

Pytal commented Feb 16, 2023

🤔 TypeScript syntax in JSDoc should work nextcloud-libraries/eslint-config#413

@susnux
Copy link
Contributor Author

susnux commented Feb 16, 2023

thinking TypeScript syntax in JSDoc should work

This part of the PR is a workaround for an upstream bug: jsdoc-type-pratt-parser/jsdoc-type-pratt-parser#141

@susnux
fix(NcPopover): Wrong JSDoc comment and missing default and type for …
655bc0c 
…`setReturnFocus` property

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
@susnux susnux requested a review from Pytal February 17, 2023 17:23
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 17, 2023
@Pytal Pytal merged commit 3cb53da into master Feb 17, 2023
@Pytal Pytal deleted the fix/props-ncpopover branch February 17, 2023 17:43
@szaimen szaimen mentioned this pull request Feb 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@Pytal Pytal Pytal approved these changes

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working feature: popover Related to the popovermenu component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@susnux @Pytal @raimund-schluessler