Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcRichContenteditable): Fix avatar overlayed with empty space whe… #4043

Merged
merged 1 commit into from May 5, 2023
Merged

fix(NcRichContenteditable): Fix avatar overlayed with empty space whe… #4043

merged 1 commit into from May 5, 2023

Conversation

nickvergessen
Copy link
Contributor

…n offline

Fix #4042

Before After
Bildschirmfoto vom 2023-05-05 13-32-18 Bildschirmfoto vom 2023-05-05 13-32-43

@nickvergessen
fix(NcRichContenteditable): Fix avatar overlayed with empty space whe…
e8bd8ba 
…n offline

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added bug Something isn't working 3. to review Waiting for reviews feature: rich-contenteditable Related to the rich-contenteditable components labels May 5, 2023
@nickvergessen nickvergessen added this to the 7.11.3 milestone May 5, 2023
@nickvergessen nickvergessen self-assigned this May 5, 2023
Antreesy
Antreesy approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦭
Fine by the code perspective

@nickvergessen nickvergessen requested a review from ShGKme May 5, 2023 11:48
@nickvergessen
Copy link
Contributor Author

/backport to stable7

ShGKme
ShGKme approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Talk

@nickvergessen nickvergessen merged commit 88ac3ad into master May 5, 2023
16 checks passed
@nickvergessen nickvergessen deleted the bugfix/4042/fix-offline-user-status-icon branch May 5, 2023 14:04
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 5, 2023
Merged
This was referenced May 8, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@Antreesy Antreesy Antreesy approved these changes

@artonge artonge Awaiting requested review from artonge

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews bug Something isn't working feature: rich-contenteditable Related to the rich-contenteditable components
Projects
None yet
Milestone
7.11.3
Development

Successfully merging this pull request may close these issues.

User Picker for @- mentions shows white circle for "invisible" status
3 participants
@nickvergessen @ShGKme @Antreesy