Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(NcActions): Readability #4049

Merged
merged 1 commit into from May 9, 2023
+2 −43
Merged

enh(NcActions): Readability #4049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/assets/action.scss
View file
Open in desktop
Expand Up @@ -61,7 +61,6 @@
cursor: pointer;
white-space: nowrap;

opacity: $opacity_normal;
color: var(--color-main-text);
border: 0;
border-radius: 0; // otherwise Safari will cut the border-radius area
Expand All @@ -72,11 +71,6 @@
font-size: var(--default-font-size);
line-height: $clickable-area;

&:hover,
&:focus {
opacity: $opacity_full;
}

& > span {
cursor: pointer;
white-space: nowrap;
Expand Down
11 changes: 0 additions & 11 deletions src/components/NcActionCheckbox/NcActionCheckbox.vue
View file
Open in desktop
Expand Up @@ -193,9 +193,6 @@ export default {
width: 1px;
height: 1px;
&:focus + .action-checkbox__label {
opacity: $opacity_full;
}
}
&__label {
Expand All @@ -206,7 +203,6 @@ export default {
padding: 0 !important;
padding-right: $icon-margin !important;
opacity: $opacity_normal;
// checkbox-width is 12px, border is 2
// (44 - 14 - 2) / 2 = 14
&::before {
Expand All @@ -220,13 +216,6 @@ export default {
cursor: pointer;
}
}
&:not(.action-checkbox--disabled):hover,
&:not(.action-checkbox--disabled):focus {
.action-checkbox__label {
opacity: $opacity_full;
}
}
}
</style>
6 changes: 0 additions & 6 deletions src/components/NcActionInput/NcActionInput.vue
View file
Open in desktop
Expand Up @@ -494,7 +494,6 @@ $input-margin: 4px;
cursor: pointer;
white-space: nowrap;
opacity: $opacity_normal;
color: var(--color-main-text);
border: 0;
border-radius: 0; // otherwise Safari will cut the border-radius area
Expand All @@ -503,11 +502,6 @@ $input-margin: 4px;
font-weight: normal;
&:hover,
&:focus {
opacity: $opacity_full;
}
&__icon-wrapper {
display: flex;
align-self: center;
Expand Down
11 changes: 0 additions & 11 deletions src/components/NcActionRadio/NcActionRadio.vue
View file
Open in desktop
Expand Up @@ -188,9 +188,6 @@ export default {

width: 1px;
height: 1px;
&:focus + .action-radio__label {
opacity: $opacity_full;
}
}

&__label {
Expand All @@ -201,7 +198,6 @@ export default {
padding: 0 !important;
padding-right: $icon-margin !important;

opacity: $opacity_normal;
// radio-width is 12px, border is 2
// (44 - 14 - 2) / 2 = 14
&::before {
Expand All @@ -215,13 +211,6 @@ export default {
cursor: pointer;
}
}

&:not(.action-radio--disabled):hover,
&:not(.action-radio--disabled):focus {
.action-radio__label {
opacity: $opacity_full;
}
}
}

</style>
10 changes: 2 additions & 8 deletions src/components/NcActionTextEditable/NcActionTextEditable.vue
View file
Open in desktop
Expand Up @@ -207,7 +207,6 @@ $input-margin: 4px;
cursor: pointer;
white-space: nowrap;

opacity: $opacity_normal;
color: var(--color-main-text);
border: 0;
border-radius: 0; // otherwise Safari will cut the border-radius area
Expand All @@ -217,11 +216,6 @@ $input-margin: 4px;
font-weight: normal;
line-height: $clickable-area;

&:hover,
&:focus {
opacity: $opacity_full;
}

& > span {
cursor: pointer;
white-space: nowrap;
Expand Down Expand Up @@ -283,8 +277,6 @@ $input-margin: 4px;
margin: 0;
padding: 7px 6px;

opacity: $opacity_full;
color: var(--color-text-maxcontrast);
border: 0;
border-radius: 50%;
/* Avoid background under border */
Expand All @@ -299,6 +291,8 @@ $input-margin: 4px;
/* Inputs inside popover supports text, submit & reset */
&__textarea {
flex: 1 1 auto;
color: inherit;
border-color: var(--color-border-maxcontrast);

min-height: #{$clickable-area * 2 - $input-margin * 2}; /* twice the element margin-y */
max-height: #{$clickable-area * 3 - $input-margin * 2}; /* twice the element margin-y */
Expand Down
1 change: 0 additions & 1 deletion src/components/NcActions/NcActions.vue
View file
Open in desktop
Expand Up @@ -1239,7 +1239,6 @@ export default {
}
&.action-item--open .action-item__menutoggle {
opacity: $opacity_full;
background-color: var(--open-background-color);
}
}
Expand Down