Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the color-primary-element* variables in components #4067

Merged
merged 1 commit into from May 12, 2023
Merged

Use the color-primary-element* variables in components #4067

merged 1 commit into from May 12, 2023

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented May 9, 2023 •
edited

Close #4070

Testing can be done with a very dark primary color in dark mode and the other way around.

I tried to test all places that I changed if they still look good but due to the amount it is possible that I've overlooked some things.

@szaimen szaimen added the 2. developing Work in progress label May 9, 2023
@szaimen szaimen force-pushed the enh/noid/primary-color-element branch 2 times, most recently from 9b77a01 to 4577a78 Compare May 9, 2023 14:26
@szaimen szaimen changed the title Use the color-primary-element variable in components Use the color-primary-element variable in button and checkboxradioswitch component May 9, 2023
@szaimen szaimen changed the title Use the color-primary-element variable in button and checkboxradioswitch component Use the color-primary-element* variables in button and checkboxradioswitch component May 9, 2023
@szaimen szaimen force-pushed the enh/noid/primary-color-element branch from 4577a78 to 9cd082e Compare May 9, 2023 14:55
This was referenced May 9, 2023
Closed
Open
@szaimen szaimen force-pushed the enh/noid/primary-color-element branch 5 times, most recently from 3906113 to 526b27d Compare May 9, 2023 16:42
@szaimen szaimen added bug Something isn't working 3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities design Design, UX, interface and interaction design and removed 2. developing Work in progress labels May 9, 2023
@szaimen szaimen marked this pull request as ready for review May 9, 2023 16:58
@szaimen szaimen changed the title Use the color-primary-element* variables in button and checkboxradioswitch component Use the color-primary-element* variables in components May 9, 2023
@szaimen szaimen force-pushed the enh/noid/primary-color-element branch from 62e15d0 to 22ab8af Compare May 10, 2023 12:46
@szaimen szaimen force-pushed the enh/noid/primary-color-element branch 3 times, most recently from ad451cf to 334fd3f Compare May 10, 2023 17:32
JuliaKirschenheuter
JuliaKirschenheuter reviewed May 11, 2023
View reviewed changes
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please make some screenshots with before / after?

@szaimen
Copy link
Contributor Author

szaimen commented May 11, 2023

Could you please make some screenshots with before / after?

This is not really going to work due to the amount of components changed. However as far as I know should only the color-primary-element variables be used in components since it is meant for them ;)

@szaimen szaimen requested a review from juliushaertl May 11, 2023 11:16
@szaimen
Use the color-primary-element* variables in components
1235b14 
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen force-pushed the enh/noid/primary-color-element branch from 334fd3f to 1235b14 Compare May 11, 2023 12:30
@szaimen
Copy link
Contributor Author

szaimen commented May 11, 2023

rebased...

@szaimen szaimen closed this May 11, 2023
@szaimen szaimen reopened this May 11, 2023
@szaimen
Copy link
Contributor Author

szaimen commented May 12, 2023

Thanks Julia! :)

@szaimen szaimen merged commit a046d27 into master May 12, 2023
19 of 26 checks passed
@szaimen szaimen deleted the enh/noid/primary-color-element branch May 12, 2023 07:07
@nickvergessen nickvergessen added this to the 8.0.0 milestone May 12, 2023
@nickvergessen
Copy link
Contributor

Is this something to backport to 7.11.x?

@szaimen
Copy link
Contributor Author

szaimen commented May 12, 2023

Is this something to backport to 7.11.x?

Fine by me to backport it

@szaimen
Copy link
Contributor Author

szaimen commented May 12, 2023

/backport to stable7

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 12, 2023
Merged
1 task
@susnux susnux mentioned this pull request Jun 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@susnux susnux Awaiting requested review from susnux

@Pytal Pytal Awaiting requested review from Pytal

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@artonge artonge Awaiting requested review from artonge

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees
No one assigned
Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working design Design, UX, interface and interaction design
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

--primary-element variable is not used throughtout components which leads to problems with theming
4 participants
@szaimen @nickvergessen @JuliaKirschenheuter @skjnldsv