Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make property "force-title" work #4157

Closed
wants to merge 1 commit into from

Conversation

datenangebot
Copy link

  • "name" and "title" were mixed up, so no titles were shown even if option "force-names" was set

☑️ Resolves

  • Fix #…

🖼️ Screenshots

🏚️ Before 🏡 After
SCR-20230525-mfxw SCR-20230525-mfnv

🚧 Tasks

  • ...

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

- "name" and "title" were mixed up, so no titles were shown even if option "force-names" was set

Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
@datenangebot datenangebot added bug Something isn't working 3. to review Waiting for reviews labels May 25, 2023
@raimund-schluessler
Copy link
Contributor

This is not a mix-up. This is a breaking change scheduled for nextcloud-vue@8. Please see #4106.

@raimund-schluessler raimund-schluessler added wontfix This will not be worked on and removed bug Something isn't working 3. to review Waiting for reviews labels May 25, 2023
@datenangebot
Copy link
Author

This is not a mix-up. This is a breaking change scheduled for nextcloud-vue@8. Please see #4106.

Ah, okay. Great. So the docs are faster than the releases... The docs tell me to use :force-name="true", but that does not work.

@raimund-schluessler
Copy link
Contributor

This is not a mix-up. This is a breaking change scheduled for nextcloud-vue@8. Please see #4106.

Ah, okay. Great. So the docs are faster than the releases... The docs tell me to use :force-name="true", but that does not work.

Yes, that is indeed a bit unfortunate, but we have to live with it at the moment. The docs target master, which is unreleased and will become nextcloud-vue@8.

The latest release is 7.11.6 from the stable7 branch, where #4106 is not included and you still have to use force-title.

@datenangebot
Copy link
Author

The latest release is 7.11.6 from the stable7 branch, where #4106 is not included and you still have to use force-title.

Okay, that's not perfect but fine for me. Thanks for clarification.
Will close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants