Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcSelect): Adapt to NcListItemIcon #4210

Merged
merged 1 commit into from Jun 14, 2023
Merged

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Jun 13, 2023

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added 3. to review Waiting for reviews regression Regression of a previous working feature feature: select Related to the NcSelect* components labels Jun 13, 2023
@Pytal Pytal added this to the 8.0.0 milestone Jun 13, 2023
@Pytal Pytal self-assigned this Jun 13, 2023
@raimund-schluessler raimund-schluessler merged commit ef2502b into master Jun 14, 2023
16 checks passed
@raimund-schluessler raimund-schluessler deleted the fix/select-user branch June 14, 2023 10:55
@skjnldsv skjnldsv mentioned this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews feature: select Related to the NcSelect* components regression Regression of a previous working feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants