Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcSelect): Styles on state change #4211

Merged
merged 2 commits into from Jun 14, 2023
Merged

fix(NcSelect): Styles on state change #4211

merged 2 commits into from Jun 14, 2023

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Jun 14, 2023

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@Pytal
fix(NcSelect): Top placement styles
05e7fa0 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
fix(NcSelect): Disabled hover should not be colored
da537d3 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added 3. to review Waiting for reviews regression Regression of a previous working feature feature: select Related to the NcSelect* components labels Jun 14, 2023
@Pytal Pytal added this to the 8.0.0 milestone Jun 14, 2023
@Pytal Pytal self-assigned this Jun 14, 2023
Antreesy
Antreesy approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and looks better now, thanks for fixing after us! 🦭

@raimund-schluessler raimund-schluessler merged commit 2f6a98c into master Jun 14, 2023
16 checks passed
@raimund-schluessler raimund-schluessler deleted the fix/select-disabled-top branch June 14, 2023 10:50
@Pytal
Copy link
Contributor Author

Pytal commented Jun 14, 2023

/backport to stable7

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 14, 2023
Merged
@skjnldsv skjnldsv mentioned this pull request Jun 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@artonge artonge artonge approved these changes

@Antreesy Antreesy Antreesy approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@susnux susnux Awaiting requested review from susnux

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews feature: select Related to the NcSelect* components regression Regression of a previous working feature
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Pytal @raimund-schluessler @artonge @Antreesy