Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcSelect): Disabled colors #4217

Merged
merged 1 commit into from Jun 16, 2023
Merged

fix(NcSelect): Disabled colors #4217

merged 1 commit into from Jun 16, 2023

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Jun 14, 2023

☑️ Resolves

  • Lighten the disabled background and text colors slightly to distinguish the disabled state from the regular state

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@Pytal Pytal added design Design, UX, interface and interaction design feature: select Related to the NcSelect* components labels Jun 14, 2023
@Pytal Pytal added this to the 8.0.0 milestone Jun 14, 2023
@Pytal Pytal self-assigned this Jun 14, 2023
@susnux
Copy link
Contributor

susnux commented Jun 15, 2023

Looks better but I think the visual difference is still not that good. How about also changing the (text) color for selected elements?

(e.g. like this, top is normal enabled and bottom is disabled)
image

.vs--disabled  .vs__search, .vs--disabled .vs__selected {
  color: var(--color-text-maxcontrast);
}

@szaimen
Copy link
Contributor

szaimen commented Jun 15, 2023

Looks better but I think the visual difference is still not that good. How about also changing the (text) color for selected elements?

(e.g. like this, top is normal enabled and bottom is disabled) image

.vs--disabled  .vs__search, .vs--disabled .vs__selected {
  color: var(--color-text-maxcontrast);
}

I agree! The proposal looks good to me!

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal requested a review from susnux June 16, 2023 00:30
@Pytal Pytal changed the title fix(NcSelect): Disabled background fix(NcSelect): Disabled colors Jun 16, 2023
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pytal Pytal added the 4. to release Ready to be released and/or waiting for tests to finish label Jun 16, 2023
@Pytal Pytal merged commit 95cdc79 into master Jun 16, 2023
16 checks passed
@Pytal Pytal deleted the fix/select-disabled branch June 16, 2023 23:28
@skjnldsv skjnldsv mentioned this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish design Design, UX, interface and interaction design feature: select Related to the NcSelect* components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants